From 8e508be2aa0302af10c5450310af7c4ef289b73c Mon Sep 17 00:00:00 2001 From: tsteven4 Date: Fri, 1 Jun 2018 09:35:44 -0600 Subject: [PATCH] clang-tidy add override specifier. -header-filter=.*\\.h -checks=-*,modernize-use-override -fix --- src/core/file.h | 2 +- src/core/usasciicodec.h | 10 +++++----- src/core/xmlstreamwriter.h | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/core/file.h b/src/core/file.h index 198cc33c8..0f16350df 100644 --- a/src/core/file.h +++ b/src/core/file.h @@ -33,7 +33,7 @@ public: File(const QString& s) : QFile(s) {} /* in the tradition of gbfile we assume WriteOnly or ReadOnly, not ReadWrite */ - bool open(OpenMode mode) { + bool open(OpenMode mode) override { bool status; if (QFile::fileName() == "-") { diff --git a/src/core/usasciicodec.h b/src/core/usasciicodec.h index 602bb6ec6..236177bb9 100644 --- a/src/core/usasciicodec.h +++ b/src/core/usasciicodec.h @@ -28,11 +28,11 @@ namespace gpsbabel class UsAsciiCodec : public QTextCodec { public: - QByteArray name() const; - QList aliases() const; - int mibEnum() const; - QString convertToUnicode(const char*, int, ConverterState*) const; - QByteArray convertFromUnicode(const QChar*, int, ConverterState*) const; + QByteArray name() const override; + QList aliases() const override; + int mibEnum() const override; + QString convertToUnicode(const char*, int, ConverterState*) const override; + QByteArray convertFromUnicode(const QChar*, int, ConverterState*) const override; }; } // namespace gpsbabel diff --git a/src/core/xmlstreamwriter.h b/src/core/xmlstreamwriter.h index 4dc27fb19..829a421cf 100644 --- a/src/core/xmlstreamwriter.h +++ b/src/core/xmlstreamwriter.h @@ -39,11 +39,11 @@ private: public: XmlTextCodec(); static XmlTextCodec *instance; - virtual QByteArray name() const; - virtual int mibEnum() const; + QByteArray name() const override; + int mibEnum() const override; protected: - virtual QByteArray convertFromUnicode(const QChar* chars, int len, QTextCodec::ConverterState* state) const; - virtual QString convertToUnicode(const char* chars, int len, QTextCodec::ConverterState* state) const; + QByteArray convertFromUnicode(const QChar* chars, int len, QTextCodec::ConverterState* state) const override; + QString convertToUnicode(const char* chars, int len, QTextCodec::ConverterState* state) const override; }; class XmlStreamWriter : public QXmlStreamWriter -- 2.30.2